enhancement: update azure cookie cutter template to support a more recent ansible syntax #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadhah101
changed the title
wadhah101
changed the title
apatard
reviewed
Apr 12, 2023
...e/cookiecutter/{{cookiecutter.molecule_directory}}/{{cookiecutter.scenario_name}}/create.yml
Outdated
Show resolved
Hide resolved
apatard
reviewed
Apr 12, 2023
...e/cookiecutter/{{cookiecutter.molecule_directory}}/{{cookiecutter.scenario_name}}/create.yml
Outdated
Show resolved
Hide resolved
apatard
reviewed
Apr 12, 2023
...e/cookiecutter/{{cookiecutter.molecule_directory}}/{{cookiecutter.scenario_name}}/create.yml
Outdated
Show resolved
Hide resolved
apatard
reviewed
Apr 12, 2023
...e/cookiecutter/{{cookiecutter.molecule_directory}}/{{cookiecutter.scenario_name}}/create.yml
Show resolved
Hide resolved
|
LGTM Thanks @wadhah101 @apatard do you have concerns? |
zhan9san
approved these changes
Apr 13, 2023
|
As we have fixed the lint issue in cookiecutter, do you have interest to add the ansible-lint in ci job? It' fine to add it in this PR or another one. Currently, the cookiecutter directory is excluded in ansible-lint configuration. It may need to run 'molecule init -d xxx' to generate the playbook from cookiecutter. |
|
@zhan9san |
This was referenced Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.