Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "podman: remove ansible_async_dir setting logic (#182)" #237

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert "podman: remove ansible_async_dir setting logic (#182)" #237

wants to merge 1 commit into from

Conversation

hswong3i
Copy link
Contributor

@hswong3i hswong3i commented Feb 12, 2024 •
edited
Loading

After upgrade to https://github.com/ansible-community/molecule-plugins/releases/tag/v23.5.3, I found that all my GitLab CI pipiline running with podman driver not working (e.g. https://gitlab.com/alvistack/docker-ubuntu/-/jobs/6148073273)

INFO     Running ubuntu-22.04-docker > destroy
Molecule ubuntu-22.04-docker > destroy 00:03
PLAY [Destroy] *****************************************************************
TASK [Destroy molecule instance(s)] ********************************************
changed: [localhost] => (item={'image': 'alvistack/ubuntu-22.04', 'name': 'eet3ufiemeeh-1', 'pre_build_image': True, 'privileged': True})
TASK [Wait for instance(s) deletion to complete] *******************************
failed: [localhost] (item={'failed': 0, 'started': 1, 'finished': 0, 'ansible_job_id': 'j345359959033.3993', 'results_file': '/home/vagrant/.ansible_async/j345359959033.3993', 'changed': True, 'item': {'image': 'alvistack/ubuntu-22.04', 'name': 'eet3ufiemeeh-1', 'pre_build_image': True, 'privileged': True}, 'ansible_loop_var': 'item'}) => {"ansible_job_id": "j345359959033.3993", "ansible_loop_var": "item", "attempts": 1, "changed": false, "finished": 1, "item": {"ansible_job_id": "j345359959033.3993", "ansible_loop_var": "item", "changed": true, "failed": 0, "finished": 0, "item": {"image": "alvistack/ubuntu-22.04", "name": "eet3ufiemeeh-1", "pre_build_image": true, "privileged": true}, "results_file": "/home/vagrant/.ansible_async/j345359959033.3993", "started": 1}, "msg": "could not find job", "results_file": "/root/.ansible_async/j345359959033.3993", "started": 1, "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}
PLAY RECAP *********************************************************************
localhost                  : ok=1    changed=1    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0

After debug I found that if disable https://github.com/ansible-community/molecule-plugins/blob/v23.5.3/src/molecule_plugins/podman/playbooks/create.yml#L167-L168 as below, the create will working fine:

    - name: Create molecule instance(s)
      containers.podman.podman_container:
      ...
      loop_control:
        label: "{{ item.name }}"      
      # async: 7200
      # poll: 0
      ---

So this lead me to the #182, which remove the ansible_async_dir logic.

After manually revert the commit 0244719, my problem get fixed:

This reverts commit 0244719.

@hswong3i
Revert "podman: remove ansible_async_dir setting logic (ansible-commu…
19610e4 
…nity#182)"

This reverts commit 0244719.

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
@github-actions GitHub Actions
Copy link

Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found:

hswong3i added a commit to alvistack/ansible-community-molecule-plugins that referenced this pull request Feb 12, 2024
@hswong3i
alvistack/v23.5.3
5da9968 
    git clean -xdf
    tar zcvf ../python-molecule-plugins_23.5.3.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-molecule-plugins.spec ../python-molecule-plugins_23.5.3-1.spec
    cp ../python*-molecule-plugins*23.5.3*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.5.3
    rm -rf ../python*-molecule-plugins*23.5.3*.*

See ansible-community#155
See ansible-community#237

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/ansible-community-molecule-plugins that referenced this pull request Feb 20, 2024
@hswong3i
alvistack/v23.5.3
01af367 
    git clean -xdf
    tar zcvf ../python-molecule-plugins_23.5.3.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-molecule-plugins.spec ../python-molecule-plugins_23.5.3-1.spec
    cp ../python*-molecule-plugins*23.5.3*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.5.3
    rm -rf ../python*-molecule-plugins*23.5.3*.*

See ansible-community#155
See ansible-community#237
See ansible-community#240

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/ansible-community-molecule-plugins that referenced this pull request Feb 28, 2024
@hswong3i
alvistack/v23.5.3
413c114 
    git clean -xdf
    tar zcvf ../python-molecule-plugins_23.5.3.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-molecule-plugins.spec ../python-molecule-plugins_23.5.3-1.spec
    cp ../python*-molecule-plugins*23.5.3*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.5.3
    rm -rf ../python*-molecule-plugins*23.5.3*.*

See ansible-community#155
See ansible-community#237
See ansible-community#240

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hswong3i