Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak CI #260

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Unbreak CI #260

merged 2 commits into from
Sep 19, 2024

Conversation

apatard
Copy link
Member

@apatard apatard commented Aug 2, 2024

  • Upgrade containers and boxes to use newer versions
  • Remove create.yml/destroy.yml templates copied by molecule with molecule init for unlucky plugins
  • Rename vagrant tests to avoid "import vagrant" in the test importing the test module instead of importing the vagrant module.
  • Move the vagrant box_url testing to its own test to avoid failures in multi-node where it would be hard to know if the issue is with the test or with the box_url test.

apatard and others added 2 commits August 2, 2024 15:37
@apatard
Unbreak CI
601332a 
- Upgrade containers and boxes to use newer versions
- Remove create.yml/destroy.yml templates copied by molecule with molecule init for unlucky plugins
- Rename vagrant tests to avoid "import vagrant" in the test importing the
  test module instead of importing the vagrant module.
- Move the vagrant box_url testing to its own test to avoid failures in multi-node
  where it would be hard to know if the issue is with the test or with the box_url test.

Signed-off-by: Arnaud Patard <arnaud.patard@collabora.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
04c03c5 
for more information, see https://pre-commit.ci
@apatard apatard added the bug Something isn't working label Aug 2, 2024
@apatard apatard marked this pull request as ready for review August 2, 2024 13:45
matt-horwood-mayden
matt-horwood-mayden approved these changes Aug 2, 2024
View reviewed changes
Copy link

@matt-horwood-mayden matt-horwood-mayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, can we merge

@apatard
Copy link
Member Author

apatard commented Aug 2, 2024

@matt-horwood-mayden well, a review from someone with write access is needed.

@matt-horwood-mayden
Copy link

matt-horwood-mayden commented Aug 5, 2024 •
edited
Loading

@apatard yeah I know 😞

@ssbarnea could you have a look at this PR please?

@konstruktoid konstruktoid mentioned this pull request Aug 5, 2024
Open
@cnfrancis
Copy link
Contributor

cnfrancis commented Sep 19, 2024 •
edited
Loading

hello! gentle bump on this @ssbarnea @cidrblock

@oraNod oraNod requested a review from ssbarnea September 19, 2024 14:55
oraNod
oraNod approved these changes Sep 19, 2024
View reviewed changes
Copy link

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apatard Thanks. I've requested a review from @ssbarnea as he is more familiar with this repo but it LGTM. If we don't get another ack soon-ish I'll merge as this seems like it's blocking stuff.

@ssbarnea ssbarnea merged commit 5ab90a0 into ansible-community:main Sep 19, 2024
10 checks passed
@basil basil mentioned this pull request Nov 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oraNod oraNod oraNod approved these changes

@matt-horwood-mayden matt-horwood-mayden matt-horwood-mayden approved these changes

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@apatard @matt-horwood-mayden @cnfrancis @ssbarnea @oraNod