Install rsync as dependency #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This plugin was moved to https://github.com/ansible-community/molecule-plugins few days ago, archiving the repo now. Raise the PR towards new location. |
|
@ssbarnea , but we already are in ansible-community/molecule-plugins repo. |
|
Oops, I got confused myself. Regarding rsync, I know that this is needed in order to allow use of synchronize with the container but I am not sure if that needed or desired to be in default template. I will ask few others users of the docker plugin. |
|
Was there an agreement about this PR ? It make sense to have it I guess. Nevertheless, I'm always using pre-built images so I can't comment. |
|
I agree to add |
zhan9san
force-pushed
the
fix_dockerrsync
branch
from
ef2352c to
3dd635f
Compare
zhan9san
approved these changes
Apr 12, 2023
apatard
force-pushed
the
fix_dockerrsync
branch
from
3dd635f to
aaa5fb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is required for syncronize module, which is rsync wrapper