Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Make cachier optional #101

Merged

Conversation

greg-hellings
Copy link
Member

Fixes #100

pip seems to be required for development style installs
Ansible chokes on the yaml stdout_callback
@greg-hellings
Copy link
Member Author

I've rebased this on top of #102 so that we can see test results here.

@ssbarnea ssbarnea added the bug Something isn't working label Apr 20, 2021
Copy link
Member

@apatard apatard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said in #100 (comment), I'm worried about the maintainance of vagrant-cachier. So, maybe disable cachier by default would be a thing but this may possibly silently break things for users :(
At least, with this PR, things remains the same, while allowing to disable cachier.

@greg-hellings
Copy link
Member Author

Cachier still works for me. It's not getting knowledge of new package types, obviously, but I haven't had any issues with it.

@greg-hellings
Copy link
Member Author

I can't see the logs from the ansible/check failures, but I'm happy to address them if I can.

@apatard
Copy link
Member

apatard commented Apr 20, 2021

The check failure is on zuul and it was a timeout and I bet it was some kind of "glitch" so nothing to do except running the checks again to see if it happens again

@apatard
Copy link
Member

apatard commented Apr 20, 2021

Cachier still works for me. It's not getting knowledge of new package types, obviously, but I haven't had any issues with it.

ok. nice. So, if it's still working, I'm happy with the current PR, as long as the checks are happy too

@apatard
Copy link
Member

apatard commented Apr 20, 2021

recheck

1 similar comment
@apatard
Copy link
Member

apatard commented Apr 21, 2021

recheck

@greg-hellings
Copy link
Member Author

This time the Ubuntu test passed, but the linter timed out. Resource contention issues? 😆

@ssbarnea
Copy link
Member

I would call it zuul-gambling... let me remove the linters at least, two failures in a single day is far more than I am willing to deal with.

@ssbarnea ssbarnea enabled auto-merge (squash) April 21, 2021 15:46
@ssbarnea ssbarnea merged commit 63253ac into ansible-community:master Apr 21, 2021
@greg-hellings greg-hellings deleted the make_cachier_optional branch April 21, 2021 18:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to disable vagrant-cachier
3 participants