This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
libvirt: automatic fallback to qemu #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
apatard
commented
Dec 17, 2021
apatard
commented
[ While it would have been better to avoid any vagrant provider specific code, there's already some. This change will add more glue to handle libvirt systems. ] Currently, the vagrant-libvirt will try to use kvm by default and will result in an error on systems without kvm, for instance, some Zuul instances. So, detect if there's a /dev/kvm and in case there's none switch to qemu driver. Moreover, things will "just" work. Having a slow CI is surely better than no CI. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
Now that the vagrant plugin is automatically switching to QEMU when kvm is not available, remove the code used to handle that at the test level. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
apatard
added
enhancement
for more information, see https://pre-commit.ci
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sorin Sbarnea <ssbarnea@redhat.com>
Co-authored-by: Sorin Sbarnea <ssbarnea@redhat.com>
ssbarnea
approved these changes
Jan 5, 2022
ssbarnea
changed the title
|
@apatard Thanks, that is indeed awesome. Out of curiosity, why I see the filename modified as part of the PR title on your changes? Are you using a tool that does append it? |
It's an old habit of (kernel) development. It's kind of wired inside my brain |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.