This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
Allow setting instance host name #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should have tested on bionic too... current CI setup will install vagrant 2.2.9 on bionic which doesn't correctly set the hostname on alpine boxes (fixed on 2.2.10)... will add one more commit to bump vagrant version. I guess that later vagrant installation will possibly need to be revisited since there are repos for deb and rpm which may be better than download packages manually... |
ssbarnea
approved these changes
Jan 5, 2022
ssbarnea
changed the title
It may be useful to be able to set the instance hostname/FQDN or to prevent vagrant to set the hostname, so add support for that. The default behaviour is unchanged: the host name is set to the instance name. Fixes: ansible-community#157 Signed-off-by: Arnaud Patard <apatard@hupstream.com>
…ge version This commit is solving two issues: - Vagrant 2.2.10 is needed at least, otherwise it will fail to properly set the hostname. 2.2.10 is already installed with manual rpm installation but not for bionic - Vagrant version for manually installed package is not the same for rpm and bionic, so rely on a variable to ensure consistency. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
apatard
added a commit
to apatard/molecule-vagrant
that referenced
this pull request
Apr 15, 2022
The current code is reduced to a big example but doesn't exactly explains how to configure things. This results in bug reports. So try to fix it. [ Note: it's already documenting hostname option from PR ansible-community#161 so this PR has to be merged after PR ansible-community#161 ] Signed-off-by: Arnaud Patard <apatard@hupstream.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be useful to be able to set the instance hostname/FQDN or to prevent
vagrant to set the hostname, so add support for that.
The default behaviour is unchanged: the host name is set to the instance
name.
Fixes: #157
Signed-off-by: Arnaud Patard apatard@hupstream.com