Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Stop testing with ansible devel on py38 #188

Merged
merged 4 commits into from
Dec 24, 2022

Conversation

ssbarnea
Copy link
Member

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Sep 14, 2022
@apatard
Copy link
Member

apatard commented Sep 14, 2022

I've been tempted to do that in the past. Sometimes the CI is getting failures due to unrelated change in -devel and it's getting in our way. On the other side, knowing in advance that some change in next molecule version will break something is useful.

So, I'm not sure what to do or if there's an easy way to get regular -devel testing against main branch but not on PR.

@greg-hellings
Copy link
Member

@apatard You can set the test to be optional, so it runs on PR. Or you can even set it to only run when branch is master and set up a cron trigger for it. Then it won't block merges but can still yield useful warnings.

@apatard
Copy link
Member

apatard commented Sep 14, 2022

@apatard You can set the test to be optional, so it runs on PR. Or you can even set it to only run when branch is master and set up a cron trigger for it. Then it won't block merges but can still yield useful warnings.

There's already a job schedule for the tox job, so the point is more to run the -devel check the way you're suggesting. I'll have to check the gha doc on how to do that. Unless @ssbarnea has time to update this PR to do it ?
(unrelated side note: I'm not getting the mails from the schedules for molecule-vagrant but that's a different matter)

@ssbarnea
Copy link
Member Author

OOps, you are right. that devel of molecule and not devel of ansible. Yep, we need to keep at least one running. I will update it.

@ssbarnea
Copy link
Member Author

At least my change proved that the issue was originating from devel and not previous release as tests passed.

@greg-hellings
Copy link
Member

You should be able to filter based on a if clause, only running the -devel tests when branch is equal to main. I know all of that information is passed through in the contexts, you'd just have to string together the proper conditional bits in the job workflow.

@apatard
Copy link
Member

apatard commented Oct 14, 2022

@ssbarnea Looks like that neither of us had time to update this PR to run testing with molecule devel only on main and not merge. Should this PR be closed ?

@ssbarnea ssbarnea changed the title Stop testing with ansible devel Stop testing with ansible devel on py38 Oct 16, 2022
@ssbarnea ssbarnea merged commit 2b4cb8f into ansible-community:main Dec 24, 2022
@ssbarnea ssbarnea deleted the fix/tests branch December 24, 2022 13:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants