This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
Silence ansible fqcn error about vagrant module. #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
suggested changes
Oct 11, 2022
Sure, this PR is the short term solution. The mid/long one is clearly to create a collection. The main blocker was python-vagrant but it's not the case anymore. Now, I need to find time and to understand how it to do that properly. I'd like also that current PR (maybe except the doc one) should either be merge or closed before, so that we start with a clean state. |
|
@ssbarnea what about this PR ? would it make sens to create also a draft PR for removing the noqa flag and using community.vagrant.vagrant as module name ? |
The local vagrant module is not (yet?) inside a collection, so there's no FQCN. Add needed noqa bits. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
ssbarnea
approved these changes
Dec 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The local vagrant module is not (yet?) inside a collection, so there's no FQCN. Add needed noqa bits.
Signed-off-by: Arnaud Patard apatard@hupstream.com