This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
molecule_vagrant/modules/vagrant.py: Improve error handling #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make sure that up() is exiting with either exit_json() or fail_json() - Catch errors for calls to vagrant.conf() and vagrant.status() - Now that the functions up/destroy/halt of the VagrantClient class should all be exiting with proper fail/exit_json, but in the case of the last line of main() is still reached, change the code to use VagrantClient result to avoid the following exception: AttributeError: 'AnsibleModule' object has no attribute 'result' Signed-off-by: Arnaud Patard <apatard@hupstream.com>
ssbarnea
approved these changes
Nov 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that up() is exiting with either exit_json() or fail_json()
Catch errors for calls to vagrant.conf() and vagrant.status()
Now that the functions up/destroy/halt of the VagrantClient class
should all be exiting with proper fail/exit_json, but in the case of
the last line of main() is still reached, change the code to use
VagrantClient result to avoid the following exception:
AttributeError: 'AnsibleModule' object has no attribute 'result'
Signed-off-by: Arnaud Patard apatard@hupstream.com