This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
Vagrant yaml removal #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
apatard
commented
Dec 2, 2020
apatard
commented
|
finally found time to run the testsuite locally with libvirt on centos8/buster/bionic/fedora32 and the testsuite is passing so, I guess, it's time to get some review and try to merge this. |
…tion After generating the Vagrantfile and vagrant.yml files, run 'vagrant validate' in order to detect syntax errors before trying to start/stop/... the VM. Unfortunately, the python vagrant binding doesn't support calling 'validate', so do it by hand with subprocess. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
Using a vagrant.yml file to store the instance configuration is adding an useless overhead and make things harder to debug. While moving the Vagrantfile generation to use only jinja2 templating, remove the hardcoded vagrant provider handling, since only vmware providers are different (cpu and memory are 'vmx['numvcpus']' and vmx['memsize']). The new way of generating vagrant configuration will also ease to improve the multiplatform support. Notes: - special vagrant-vbguest handling with virtualvbox provider removed - to remain "bug" compatible for now, things like nic_model_type: '"e1000"' are still working, even if the new way is nic_model_type: e1000 (or "e1000"). This will maybe vanish with multiplatform, since it'll probably introduce breakage due to different module arguments. Fixes: ansible-community#86 Signed-off-by: Arnaud Patard <apatard@hupstream.com>
With the vagrant.yml removal, it's now possible to remove the extra
quotes ("'e1000'" vs "e1000"/e1000) so update the README and testsuite
to reflect that.
Signed-off-by: Arnaud Patard <apatard@hupstream.com>
apatard
force-pushed
the
vagrant_yaml_removal
branch
from
da43437
to
59e7429
Compare
|
recheck |
ssbarnea
approved these changes
Dec 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.