add box_download_checksum support (rewrite)

[konstruktoid]

#90 rewrite

Signed-off-by: Thomas Sjögren konstruktoid@users.noreply.github.com

[apatard]

Looks a good idea (even if I would prefer GPG to verify things but it's not possible since Vagrant doesn't support that.). I've only comments on the way things have been implemented. Please address them.

[apatard]

Even if a better commit message would be nice, I'm not sure there's a defined policy about it, so I'm fine with it.
The settings may be already be set with other module options, as for box_version or box_url but some options like this possibly deserve an easy way to set them.

[konstruktoid]

You're referring to 73a6e51? Yeah, that was a poor one. Updated the PR title.

What do you mean by The settings may be already be set with other module options? The standard Vagrantfile options are https://www.vagrantup.com/docs/vagrantfile/machine_settings#config-vm-box_download_checksum and https://www.vagrantup.com/docs/vagrantfile/machine_settings#config-vm-box_download_checksum_type. I don't really see any reason to deviate from those.

[apatard]

What do you mean by The settings may be already be set with other module options? The standard Vagrantfile options are https://www.vagrantup.com/docs/vagrantfile/machine_settings#config-vm-box_download_checksum and https://www.vagrantup.com/docs/vagrantfile/machine_settings#config-vm-box_download_checksum_type. I don't really see any reason to deviate from those.

oh, I was unclear. Sorry, I was talking of using config_options or instance_raw_config_args in the molecule.yml file.

[konstruktoid]

I agree, but that discussion seems off topic in this PR. New issue/discussion?

[apatard]

I agree, but that discussion seems off topic in this PR. New issue/discussion?

Oh, no need for a new issue/discussion. I only wanted to explain why I was approving the PR.