This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
Force lower case when using provider.name as variable #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ider.name as variable
When using {{ instance.provider }} as variable in the generated
Vagrantfile, it has to respect ruby syntax, so the first letter
has to be a lower case.
Until recently, either the user was using the provider name as the one
specified in the Vagrant documentation or it was specifying the
wrong name (like VirtualBox or VBox) and things were "just" working,
since Vagrant will default to virtualbox in case it didn't find the
configured provider.
In the vagrant.yml removal patch, I've used the provider name as variable
and with the provider set to 'VirtualBox', this will now produced the
following ruby error:
Vagrantfile:45: formal argument cannot be a constant
So, even if it may be considered as a configuration error, it's
better to ensure on our side to not produce an invalid file.
The change is limited to this part of the Vagrantfile, as I guess
that user will respect the casing for the other configuration options.
Fix: ansible-community#91
Signed-off-by: Arnaud Patard <apatard@hupstream.com>
ssbarnea
changed the title
ssbarnea
approved these changes
Apr 20, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using {{ instance.provider }} as variable in the generated
Vagrantfile, it has to respect ruby syntax, so the first letter
has to be a lower case.
Until recently, either the user was using the provider name as the one
specified in the Vagrant documentation or it was specifying the
wrong name (like VirtualBox or VBox) and things were "just" working,
since Vagrant will default to virtualbox in case it didn't find the
configured provider.
In the vagrant.yml removal patch, I've used the provider name as variable
and with the provider set to 'VirtualBox', this will now produced the
following ruby error:
Vagrantfile:45: formal argument cannot be a constant
So, even if it may be considered as a configuration error, it's
better to ensure on our side to not produce an invalid file.
The change is limited to this part of the Vagrantfile, as I guess
that user will respect the casing for the other configuration options.
Fix: #91
Signed-off-by: Arnaud Patard apatard@hupstream.com