Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

Decouple pytest-molecule from ansible package #85

Closed
yajo opened this issue Oct 29, 2020 · 2 comments · Fixed by ansible/molecule#2954
Closed

Decouple pytest-molecule from ansible package #85

yajo opened this issue Oct 29, 2020 · 2 comments · Fixed by ansible/molecule#2954
Assignees
Labels
bug This issue/PR relates to a bug.

Comments

@yajo
Copy link

yajo commented Oct 29, 2020

AFAICS molecule itself now allows to use ansible-base: ansible/molecule#2805

However, installing pytest-molecule installs the full ansible distribution.

IMHO this package should reflect upstream's decision.

@ssbarnea
Copy link
Member

In fact is even more than this, take a look at ansible/molecule#2926 -- Molecule 3.2 no longer needs Ansible installed inside the same python interpreter. This means that we need to update pytest-molecule to prevent it from bringing Ansible as a dependency too.

There is a list of molecule related projects that need the same type of change for decoupling from Ansible python package.

If you can make a PR to do it it would be great.

@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label Oct 29, 2020
@ssbarnea ssbarnea changed the title Depend on ansible-base Decouple pytest-molecule from ansible package Oct 29, 2020
@ssbarnea ssbarnea self-assigned this Nov 7, 2020
@ssbarnea
Copy link
Member

ssbarnea commented Nov 7, 2020

It may seem weird but this bug is not on pytest-molecule, is in fact a molecule bug regarding how its extras are configured, mainly because test extra includes ansible and ansible-lint, which it should not. They should be installed by ansilbe and lint extras. Test extra should be limited to install only testing tools for molecule itself and its extensions and deliberately avoid dragging ansible in by accident.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants