-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task validation fixes (by Steampunk Spotter) #321
Task validation fixes (by Steampunk Spotter) #321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick and very comprehensive feedback for this PR. I have made a couple of comments that would be great to discuss further.
thanks
uk-bolly
c1bca28
to
ff4d96e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
hi @anzoman Thank you again for your work on this and the great comms. I have just noted that you last push is not meeting DCO requirements apart from that i am happy to approve. thanks again uk-bolly |
Signed-off-by: Anže Luzar <anze.luzar@xlab.si>
Signed-off-by: Anže Luzar <anze.luzar@xlab.si>
Signed-off-by: Anže Luzar <anze.luzar@xlab.si>
Signed-off-by: Anže Luzar <anze.luzar@xlab.si>
Signed-off-by: Anže Luzar <anze.luzar@xlab.si>
Signed-off-by: Anže Luzar <anze.luzar@xlab.si>
ff4d96e
to
aa610ce
Compare
Overall Review of Changes:
These changes will try to correct some errors and warnings within Ansible tasks that I have come across when running some checks with Steampunk Spotter.
Enhancements:
These changes fix the following errors detected by the Spotter CLI:
How has this been tested?:
N/A