Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr 252 6 2 9 #255

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Pr 252 6 2 9 #255

merged 2 commits into from
Feb 15, 2023

Conversation

uk-bolly
Copy link
Member

Overall Review of Changes:
Great work in #252
thanks to @dulin-gnet highlighting this control can cause issues.,
This has been further confirmed by the community

Issue Fixes:
#252

Default for control 6.2.9 is to not follow symlinks. This is a variable that can be overridden if some users are still using in the original way and wish to revert to follow_symlinks.

Enhancements:
As above

How has this been tested?:
Manually

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly uk-bolly marked this pull request as ready for review February 14, 2023 14:17
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@uk-bolly uk-bolly merged commit 34bb386 into devel Feb 15, 2023
@uk-bolly uk-bolly deleted the PR_252-6_2_9 branch February 15, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants