Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

April23 updates #285

Merged
merged 7 commits into from
May 2, 2023
Merged

April23 updates #285

merged 7 commits into from
May 2, 2023

Conversation

uk-bolly
Copy link
Member

Overall Review of Changes:
Address issues and applied updates

Issue Fixes:
thanks to @Crayeth

  • #278
    • Added new options to allow ipv6 rules if required although ipv6 disabled
    • rhel8cis_ipv6_sysctl_force
    • default: true

thanks to @bbaassssiiee

  • #279
  • #280
  • #281
  • #284
    • new option to allow manual changes to pamd files without using authconfig
    • rhel8cis_5_4_2_risks need sto be set to ACCEPT to run
    • default: NEVER

Enhancements:
See issues

How has this been tested?:
Manually

uk-bolly added 6 commits April 25, 2023 12:07
@uk-bolly
#278
78f17c0 
Added new options

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
#281
e8b8d95 
updated control 5.3.7

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
#284
846b5ef 
faillock without authconfig option read changelog

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
updated
080629a 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
removed the sugroup check ad builtin now
5ce4d21 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
Added pre task information to name
fd6bac4 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
MrSteve81
MrSteve81 previously approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@MrSteve81 MrSteve81 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

@uk-bolly
updated ansible user check
21228a8 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly uk-bolly marked this pull request as ready for review May 2, 2023 15:50
georgenalen
georgenalen approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

bbaassssiiee
bbaassssiiee approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@bbaassssiiee bbaassssiiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uk-bolly uk-bolly merged commit 3442b94 into devel May 2, 2023
@uk-bolly uk-bolly deleted the april23_updates branch May 2, 2023 21:36
@uk-bolly uk-bolly mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgenalen georgenalen georgenalen approved these changes

@bbaassssiiee bbaassssiiee bbaassssiiee approved these changes

@MrSteve81 MrSteve81 MrSteve81 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uk-bolly @bbaassssiiee @georgenalen @MrSteve81