Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

April 24 updates #224

Merged
merged 13 commits into from
Apr 18, 2024
Merged

April 24 updates #224

merged 13 commits into from
Apr 18, 2024

Conversation

uk-bolly
Copy link
Member

Overall Review of Changes:

General tidy up and audit controls

Issue Fixes:
#223

Enhancements:

  • audit
    • moved the audit to run prior to any changes taking place on the system (exception of required)
    • improvements to copy/archive/get_url content methods incl notes in defaults/main.yml
    • tidy up and logic of var naming
  • lint and tidy up
  • ansible version update
  • unused filesystem added to skip if container list
  • unused vars removed

How has this been tested?:
Manually and community feedback

uk-bolly added 13 commits April 11, 2024 15:41
@uk-bolly
updated audit varaiblea and logic
f8ab3bb 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
lint tidy up
97bd42e 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
removed unused vars
a3974d3 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
standard quotes around mode
0400834 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
Added unused filesystem type to skip if container
de7430a 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
changed true to false
de3f7ed 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
Added nfs client back in error
9cc2561 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
updated ansible version
8a2d2b9 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
updated readme
12e6855 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
updated copy, archive, get_url options
72ac718 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
tidy up - lint
e499286 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
updated
5c0e3da 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
updated
9449a20 
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly uk-bolly requested a review from MrSteve81 April 15, 2024 15:57
georgenalen
georgenalen approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@uk-bolly uk-bolly merged commit ec9745a into devel Apr 18, 2024
4 checks passed
@uk-bolly uk-bolly deleted the April_24_updates branch April 18, 2024 15:17
@uk-bolly uk-bolly mentioned this pull request Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgenalen georgenalen georgenalen approved these changes

@MrSteve81 MrSteve81 Awaiting requested review from MrSteve81

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uk-bolly @georgenalen