Address several documented usability issues #181
Conversation
ansible_builder/utils.py
Outdated
| if command[0] in constants.runtime_files: | ||
| msg += "\nPlease specify a different --container-runtime." | ||
| msg += "\nOption avaibility: {0}.".format( | ||
| ', '.join([f'{runtime}: {bool(shutil.which(runtime))}' for runtime in constants.runtime_files]) |
There was a problem hiding this comment.
@chrismeyersfsu I don't want to get bogged down in grammar, current demo:
You do not have podman installed.
Please specify a different --container-runtime.
Detected installed: podman: False, docker: True.
I will change this wording, if you will tell me exactly what it should say, because it's going to be really easy to second-guess and iterate on a million tiny changes.
There was a problem hiding this comment.
You do not have podman installed.
podman is the default container runtime. Please either install podman or specify an alternative supported container runtime by passing --container-runtime on the command line. Below are the list of supported container runtime's and whether or not they were found on your system.
podman not installed
docker installed
There was a problem hiding this comment.
podman is the default container runtime.
That doesn't make sense for this error. It could have been the default, or it could have been the user-provided value by --container-runtime=podman (or repeat this situation for docker). The default and the value we're trying to use are not the same things.
I'll delete that sentence and see how it looks.
There was a problem hiding this comment.
You do not have docker installed.
Please either install docker or specify an alternative container runtime by passing --container-runtime on the command line.
Below are the supported container runtimes and whether or not they were found on your system.
podman: not installed, docker: not installed
with latest commit, tested.
looks like a re-occurrence of the cleanup bugs |
|
recheck |
AlanCoding
force-pushed
the
misc_stuff
branch
from
b3dc39d to
ab6c66c
Compare
AlanCoding
force-pushed
the
misc_stuff
branch
from
14c2788 to
a86720c
Compare
|
No idea what's going on here
|
I just want to clear some things out
Connect #128
Connect #127
Connect #152