Improve test performance and organization #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mock out real system return value since different operating systems do not always respond the same to invalid flags. Specifically sleep on macOS does not exit 1 for invalid values for [seconds]. This caused the unit test to fail on macOS.
Integration tests running in parallel can cause this.
Update tests to be more reliable and not subject to race condition.
Remove used of tempfile in tests Use Path objects rather than strings for paths
github-actions
bot
added
needs_triage
Shrews
approved these changes
Dec 9, 2021
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
samdoran
added a commit
to samdoran/ansible-builder
that referenced
this pull request
Dec 9, 2021
Improve test performance and organization Move unit tests to test/unit. Use tmp_path fixture instead of tmpdir Use mocker fixture Reviewed-by: David Shrewsbury <None> Reviewed-by: None <None>. (cherry picked from commit 1ad38e4) Co-authored-by: Sam Doran <sdoran@redhat.com>
samdoran
added a commit
to samdoran/ansible-builder
that referenced
this pull request
Dec 9, 2021
Improve test performance and organization Move unit tests to test/unit. Use tmp_path fixture instead of tmpdir Use mocker fixture Reviewed-by: David Shrewsbury <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move unit tests to
test/unit.Use
tmp_pathfixture instead oftmpdirUse
mockerfixture