Normalize python package names during sanitization #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
sivel
reviewed
Mar 8, 2022
|
Build succeeded.
|
|
Build succeeded.
|
Shrews
changed the title
Co-authored-by: Matt Martz <matt@sivel.net>
|
Build succeeded.
|
|
@shanemcd When you return from PTO, can you review this for us? |
Shrews
added a commit
to Shrews/ansible-builder
that referenced
this pull request
Mar 21, 2022
Normalize python package names during sanitization Fixes ansible#351 Older versions of pip cannot handle duplicate entries of a python package within a requirements file. E.g., python-dateutil>=2.8.2 python_dateutil Newer versions of pip can handle this fine. ansible-builder sanitizes requirements from multiple sources (collections) by removing duplicates. However, it doesn't currently account for package names that are not normalized (python-dateutil should be the same as python_dateutil). So in an EE environment with older versions of pip, the pip install portion could fail with an error similar to: ERROR: Double requirement given: python-dateutil>=2.8.2 (from -r /tmp/r.txt (line 2)) (already in python_dateutil (from -r /tmp/r.txt (line 1)), name='python-dateutil') This change normalizes the package names (since the underlying parsing library is not doing that for us). Reviewed-by: Matt Martz <matt@sivel.net> Reviewed-by: Shane McDonald <me@shanemcd.com> (cherry picked from commit db9e74a)
Shrews
added a commit
that referenced
this pull request
Mar 21, 2022
Normalize python package names during sanitization Fixes #351 Older versions of pip cannot handle duplicate entries of a python package within a requirements file. E.g., python-dateutil>=2.8.2 python_dateutil Newer versions of pip can handle this fine. ansible-builder sanitizes requirements from multiple sources (collections) by removing duplicates. However, it doesn't currently account for package names that are not normalized (python-dateutil should be the same as python_dateutil). So in an EE environment with older versions of pip, the pip install portion could fail with an error similar to: ERROR: Double requirement given: python-dateutil>=2.8.2 (from -r /tmp/r.txt (line 2)) (already in python_dateutil (from -r /tmp/r.txt (line 1)), name='python-dateutil') This change normalizes the package names (since the underlying parsing library is not doing that for us). Reviewed-by: Matt Martz <matt@sivel.net> Reviewed-by: Shane McDonald <me@shanemcd.com> (cherry picked from commit db9e74a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #351
Older versions of pip cannot handle duplicate entries of a python package within a requirements file. E.g.,
Newer versions of pip can handle this fine.
ansible-buildersanitizes requirements from multiple sources (collections) by removing duplicates. However, it doesn't currently account for package names that are not normalized (python-dateutilshould be the same aspython_dateutil). So in an EE environment with older versions of pip, the pip install portion could fail with an error similar to:This change normalizes the package names (since the underlying parsing library is not doing that for us).