Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster integration tests #495

Merged
merged 4 commits into from
Apr 27, 2023
Merged

Conversation

nitzmahone
Copy link
Member

Speed up slowest integration tests

  • use some builder v3 shortcuts to bypass slow/repetitive work that's not applicable to what we're testing
  • also got rid of a bunch of xfails for things that should now test reliably under both podman and docker

* use some builder v3 shortcuts to bypass slow/repetitive work that's not applicable to what we're testing
* also got rid of a bunch of xfails for things that should now test reliably under both podman and docker
@nitzmahone nitzmahone requested a review from a team as a code owner April 26, 2023 18:18
@github-actions github-actions bot added the needs_triage New item that needs to be triaged label Apr 26, 2023
@github-actions github-actions bot added the test Changes to test files label Apr 27, 2023
@nitzmahone nitzmahone force-pushed the faster_integration_tests branch 2 times, most recently from cf52bed to 853ceaa Compare April 27, 2023 01:25
* adds a new pytest CLI option `--run-destructive`; tests marked `destructive` will skip when run without this option 
* enforces `serial` marking, skips any test so-marked if `numprocesses` is present and not 0 (we can't see `1` with xdist)
* tox will run both integration and pulp-integration tests with non-serial followed by serial
* CI defaults to adding `--run-destructive` on integration/pulp-integration
@nitzmahone nitzmahone force-pushed the faster_integration_tests branch from 853ceaa to 4d59900 Compare April 27, 2023 01:34
python_path: '/usr/libexec/platform-python'

options:
package_manager_path: '/bin/true'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever.


images:
base_image:
name: quay.io/centos/centos:stream9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I'd really like to move away from using this image due to stability issues. Doesn't have to happen now, but just FYI.

@Shrews Shrews merged commit 613f24f into ansible:devel Apr 27, 2023
@Akasurde Akasurde removed the needs_triage New item that needs to be triaged label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Changes to test files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants