Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change squash default from 'new' to 'off' #503

Closed
wants to merge 1 commit into from
Closed

Change squash default from 'new' to 'off' #503

wants to merge 1 commit into from

Conversation

Shrews
Copy link
Contributor

@Shrews Shrews commented Apr 27, 2023

No description provided.

@Shrews Shrews requested a review from a team as a code owner April 27, 2023 19:08
@github-actions github-actions bot added docs Changes to documentation needs_triage New item that needs to be triaged labels Apr 27, 2023
nitzmahone
nitzmahone approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@nitzmahone nitzmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 🤞 the tests pass - thanks!

Does make me realize we don't have a good place to communicate breaking changes though, which this technically is...

@nitzmahone nitzmahone mentioned this pull request May 3, 2023
Merged
@Shrews Shrews closed this May 3, 2023
@Shrews Shrews deleted the squash-default branch May 3, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
docs Changes to documentation needs_triage New item that needs to be triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shrews @nitzmahone