explicitly set WORKDIR on builder stage #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes weird COPY failures with inherited WORKDIR from some base images in `podman build` when `--squash` is in use
Shrews
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #501
podman buildwhen--squashis in useThe underlying issue looks to be a nasty
podmanbug around inheritedWORKDIRfrom other ephemeral stages that only manifests when--squashis in use, but I'm unable to reproduce on a vanilla image. Just changing theCOPYto be absolute seems like a better/"also good" fix, but it actually causespodman buildto segfault (vs successfully copying files into the ether). So we'll live to diagnose that particular issue another day...