Support multiple -v for verbosity #564
Conversation
Shrews
force-pushed
the
verbosity
branch
2 times, most recently
from
4115bd6 to
aa66bcc
Compare
| type=int, | ||
| choices=[0, 1, 2, 3], | ||
| action=CustomVerbosityAction, | ||
| nargs='?', |
There was a problem hiding this comment.
nargs='?' is potentially a big hammer here, since it can falsely trip when it's the last non-positional arg followed by a positional arg (and I can't recall offhand if you can "push" a token back for the next subparser). -- makes it work, but a lot of people don't understand that.
I think at least for builder, It's actually OK right now, since none of our existing command subparsers currently support trailing posargs, but just something to acknowledge (as well as perhaps a good reason to actually deprecate the numeric syntax?), and to make sure that an existing runner subparser doesn't have this problem.
There was a problem hiding this comment.
It should be cool for now b/c we don't have positional args, but I did add deprecating the old style in a new deprecation tracking issue #565.
|
(and bee-tee-dubs, THANK YOU) |
No description provided.