Support extra build command args #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2024
Shrews
force-pushed
the
extra-build-cli-args
branch
from
8b66317 to
8d49fb7
Compare
Shrews
force-pushed
the
extra-build-cli-args
branch
from
8d49fb7 to
ef3f256
Compare
sivel
reviewed
May 29, 2024
Shrews
force-pushed
the
extra-build-cli-args
branch
from
c0fc81d to
c12d2fd
Compare
sivel
approved these changes
May 29, 2024
Akasurde
reviewed
May 29, 2024
Akasurde
reviewed
May 29, 2024
Akasurde
reviewed
May 29, 2024
nitzmahone
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Taking bets on how long before someone complains about the shlex.split() preventing passthru of a weirdly complex quoted thing, but since it's just a convenience anyway and they can always call the builder directly, it's probably not worth trying to be any fancier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New CLI argument
--extra-build-cli-argsthat acts as a pass-through to thebuildcommand.Fixes #668