Resolve Ansible Builder Errors for Podman on Windows #717
Conversation
This fixes an issue for Podman on Windows, which copies over executable files without the executable bit on, which causes subsequent Containerfile steps to fail. By explicitly marking copied files as executable, this issue is remedied, and Ansible Builder is made usable on more platforms.
Since Containerfiles use a POSIX-like syntax, and I don't believe that Windows containers are supported base images, I think it's safe to say that Windows hosts should not insert backslash characters into entrypoint path for their Containerfiles.
This adds a unit test to make sure that when Windows NT path separator characters are preferred by os.path, the entrypoint will still be defined with POSIX path separators.
|
|
Thanks for the contribution! Unfortunately, we don't really support Windows for builder, and do not have any testing for that platform in our CI. There are currently no plans to add support either. However, I'm totally fine with the addition of the |
Hey @Shrews, thanks for the reply! While I'm happy to remove the path-handling changes, if there is no intention to support Windows for Ansible Builder, what is the purpose of using Since the path-handling changes in the PR merely force the usage of POSIX conventions when creating the Containerfile, it feels ironic and self-defeating to reintroduce Windows-specific path separators for the sole purpose of ensuring the project continues to misbehave on Windows. If you would still prefer that I remove path-handling changes to ensure continued misbehavior on Windows, I'm of course still happy to do so. Thank you again for the feedback, and please let me know if there is anything else I can share! Sincerely, |
Hey team!
I recently tried using Ansible Builder to create Ansible execution environments on my Windows machine with Podman, and I ran into a few issues.
ENTRYPOINTpath, preventing the container from running.These changes add the
--chmodflag to theCOPYcommands in the Containerfile, ensuring the scripts run correctly and ensuring behavioral parity between Podman and Docker. They also use the POSIX path separator when creating theENTRYPOINTdirective.I've added unit tests to validate the path character behavior, and I've updated existing tests for the COPY directive. After applying these changes, I was able to use Ansible Builder to create a container with a usable Ansible installation inside (using Fedora as the base image).
If you guys could incorporate these changes into the project when you get the chance, I would deeply appreciate it (and please let me know if there is anything else I can do)!
Sincerely,
Kevin