-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python 3.9 ? #2
Comments
I think most of it is >=3.9 compatible except for this portion which I'm trying to figure out. The importlib.resources.files method doesn't seem to behave the same way with py3.9 and throws a traceback. Not sure what changed between 3.9 and 3.11, not much in the docs.
|
The one thing you might try here is a dependency on this https://pypi.org/project/importlib-resources if python < 3.10. It sometimes behaves better than the version baked in. You'll have to have a conditional import in the file, something like this https://github.com/ansible/ansible-navigator/blob/main/src/ansible_navigator/utils/compatibility.py#L18 |
@cidrblock That worked! |
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* update init-path behaviour Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * debug Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * update init-path behaviour Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * maybe a fix Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * maybe a fix - 2 Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * maybe a fix - 2 Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * maybe a fix - 3 Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * maybe a fix - 4 Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * maybe a fix - 5 Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * check stderr Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * hopefully works Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * hopefully works #2 Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * hopefully works #3 Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * hopefully works #4 Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * add a comment on what was done Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * Bump mkdocs-material to 9.5.17 Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> --------- Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
https://github.com/NilashishC/ansible-creator/blob/8e39a85e71a22c6607095a6cc890247ece55c2fc/pyproject.toml#L9
I was hoping to make the ansible-cdk python 3.9, can you drop this down?
https://github.com/ansible-community/ansible-cdk/blob/main/pyproject.toml#L29
The text was updated successfully, but these errors were encountered: