Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of init functionality #290

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Cleanup of init functionality #290

merged 5 commits into from
Sep 12, 2024

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Sep 9, 2024 •
edited
Loading

Fixes #289

So far this

  • removes the resetting of args.scm_org and args.scm_project internally
  • switches to using playbook instead of ansible-project internally

and probably has unintended consequences

I think I've cleaned up all the references to either now.

@Qalthos Qalthos added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Sep 9, 2024
@Qalthos Qalthos changed the title Unsplit collection internally Cleanup of init functionality Sep 9, 2024
@Qalthos Qalthos marked this pull request as ready for review September 11, 2024 15:26
@Qalthos Qalthos requested a review from a team as a code owner September 11, 2024 15:26
@Qalthos Qalthos requested review from TamiTakamiya, tanwigeetika1618 and shatakshiiii and removed request for a team September 11, 2024 15:26
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

shatakshiiii
shatakshiiii approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@shatakshiiii shatakshiiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Qalthos Qalthos merged commit d1b03cc into ansible:main Sep 12, 2024
17 checks passed
@Qalthos Qalthos deleted the init-cleanup branch September 12, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatakshiiii shatakshiiii shatakshiiii approved these changes

@alisonlhart alisonlhart alisonlhart approved these changes

@TamiTakamiya TamiTakamiya Awaiting requested review from TamiTakamiya TamiTakamiya is a code owner automatically assigned from ansible/devtools

@tanwigeetika1618 tanwigeetika1618 Awaiting requested review from tanwigeetika1618 tanwigeetika1618 is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code cleanup in the existing init functionality
3 participants
@Qalthos @alisonlhart @shatakshiiii