Add --(no-)overwrite parameters to control override ability
#298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shatakshiiii Can we open this PR up for review and merge this please? |
shatakshiiii
requested review from
ssbarnea,
alisonlhart,
cidrblock and
a team
and removed request for
a team
shatakshiiii
changed the title
--overwrite parameter --overwrite and no-overwrite parameters to clean-up force functionality
tanwigeetika1618
approved these changes
Oct 9, 2024
ssbarnea
changed the title
--overwrite and no-overwrite parameters to clean-up force functionality--(no-)overwrite parameters to control override ability
ssbarnea
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR for #294, that introduces
--overwriteparameter that can overwrite existing files or directories and a subsequent--no-overwriteflag that restricts this operation.When scaffolding a project on top of an existing directory, now you will see a WARNING message first that indicates conflicting files in the dest whose content differs to what we are supposed to scaffold. Followed by a prompt asking you to proceed with the overwriting operation.
Once you proceed with the YES, we overwrite those files with the intended content for that particular project.
Proceeding with NO, shows you an ERROR message that recommends using
--overwriteargument in CLI.There are no changes in
--forcein this PR. So it will behave as it is for now, until we deprecate force. There will be a follow up PR to add thedeprecating soonmessage for force parameter.Fixes: #163