Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for py313 #316

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Add support for py313 #316

merged 1 commit into from
Nov 6, 2024

Conversation

abhikdps
Copy link
Contributor

@abhikdps abhikdps commented Nov 6, 2024

@abhikdps abhikdps added the enhancement New feature or request label Nov 6, 2024
@abhikdps abhikdps self-assigned this Nov 6, 2024
@github-actions github-actions bot added the skip-changelog Skip changelog check when this label is found. label Nov 6, 2024
@abhikdps abhikdps removed the skip-changelog Skip changelog check when this label is found. label Nov 6, 2024
@abhikdps abhikdps marked this pull request as ready for review November 6, 2024 09:55
@abhikdps abhikdps requested a review from a team as a code owner November 6, 2024 09:55
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to update tox.yml workflow to include py313 pipeline

@abhikdps
Copy link
Contributor Author

abhikdps commented Nov 6, 2024

You forgot to update tox.yml workflow to include py313 pipeline

Ansible creator uses the tox from team-devtools:
https://github.com/ansible/ansible-creator/blob/main/.github/workflows/tox.yml#L19

@abhikdps abhikdps requested a review from ssbarnea November 6, 2024 13:56
@ssbarnea
Copy link
Member

ssbarnea commented Nov 6, 2024

You forgot to update tox.yml workflow to include py313 pipeline

Ansible creator uses the tox from team-devtools: main/.github/workflows/tox.yml#L19

You need to add argument max_python: "3.13" to ensure it will run with 3.13. If you see at the list of jobs executed, you will see that 3.13 is missing.

@ssbarnea ssbarnea closed this Nov 6, 2024
@ssbarnea ssbarnea reopened this Nov 6, 2024
@ssbarnea
Copy link
Member

ssbarnea commented Nov 6, 2024

Lets see if it will run now....

@ssbarnea
Copy link
Member

ssbarnea commented Nov 6, 2024

@tanwigeetika1618 You should have noted that py313 did not run before approving. Now it has it but initially it did not. If we don't test, we don't know if it works.

@ssbarnea ssbarnea enabled auto-merge (squash) November 6, 2024 14:01
@ssbarnea ssbarnea merged commit 56f3f5e into ansible:main Nov 6, 2024
30 of 32 checks passed
@abhikdps abhikdps deleted the chore/ci branch November 6, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants