-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pip-compile session to Python 3.11 #1614
Comments
@gotmax23 @felixfontein @webknjaz Hi! Can you please take a look at this and provide your thoughts and input? I would like to do two things:
I do recall some discussion about the Python versions but the rationale behind them doesn't seem to be captured, even though we call out 3.10 in the README: https://github.com/ansible/ansible-documentation/blob/devel/README.md#updating-dependencies Here is the issue where we added the noxfile for reference: #54 |
This adjusts the devel branch to use Python 3.11 to generate dependencies with pip-compile. This also adjusts the pip-compile-dev workflow to run separate jobs for the stable branches. It's not a very DRY approach; Github Actions does not support loops. Fixes: ansible#1614 Fixes: ansible#1450
This adjusts the devel branch to use Python 3.11 to generate dependencies with pip-compile. This also adjusts the pip-compile-dev workflow to run separate jobs for the stable branches, which will still use Python 3.10 for requirements files. It's not a very DRY approach; Github Actions does not support loops. Fixes: ansible#1614 Fixes: ansible#1450
Doesn't this also make make #1252 redundant? I've been digging through for tools related issues to pick up, and both this reads to me like a superset of what we were looking at for that one. |
This adjusts the devel branch to use Python 3.11 to generate dependencies with pip-compile. This also adjusts the pip-compile-dev workflow to run separate jobs for the stable branches, which will still use Python 3.10 for requirements files. Fixes: ansible#1614 Fixes: ansible#1450
Ansible core dropped support for Python 3.10 with ansible/ansible@b2a289d
Given that docs are built on the core repo using Python 3.10 causes a failure when the build calls in to
hacking/build-ansible.py
. This change might warrant bumping the Python version that we use to pip compile project dependencies to be inline with the minimum supported version for core devel.Potential changes to these files:
ansible-documentation/noxfile.py
Line 91 in deaf1fd
ansible-documentation/.github/workflows/pip-compile-dev.yml
Line 37 in deaf1fd
ansible-documentation/.github/workflows/pip-compile-docs.yml
Line 37 in deaf1fd
ansible-documentation/.github/workflows/reusable-pip-compile.yml
Line 58 in deaf1fd
The text was updated successfully, but these errors were encountered: