Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Scheduled Job Runs #2022

Closed
wants to merge 2 commits into from
Closed

Conversation

x1101
Copy link
Contributor

@x1101 x1101 commented Oct 15, 2024

Create base document for scheduled jobs.

I'd like to add descriptions to these going forward, but just getting the schedules documented in a single location is a start.

@oraNod
Copy link
Contributor

oraNod commented Oct 16, 2024

Thanks @x1101 What about adding this to the maintainers file? https://github.com/ansible/ansible-documentation/blob/devel/MAINTAINERS.md

I think these details are more relevant to the folks who maintain the repo. Honestly, adding a small .md doc to the root seems like it might add clutter.

Copy link
Contributor Author

@x1101 x1101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call @oraNod. I did this as a starting point, but I agree a random floating file is less useful, and likely more confusing, than adding it to MAINTAINERS.

Updated.

Copy link
Collaborator

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea here (and thanks for working on it, @x1101!), but I worry that the extra maintenance burden keeping this updated will create is not worth it when the schedules are already defined in the workflow files in a reasonably clear way.

What do others think?

@oraNod
Copy link
Contributor

oraNod commented Oct 23, 2024

I agree with @gotmax23 I really like the idea behind this @x1101 but I feel like this will eventually get out of sync. I guess an alternative is to use the "permalink" feature to reference the cron line in the workflow but that feels somewhat superfluous to me.

What do you think @x1101 would you be OK if we just close this one under the "useful but introduces too much maintenance" category? Or do you think there's still some usefulness that I'm not considering? Thanks again!

@x1101
Copy link
Contributor Author

x1101 commented Oct 23, 2024

Sure. As noted, I'd initially done this mostly to get my head around the schedule and then discussions came up in the DaWGs meeting that it might be more broadly useful.

If it's introducing more lift that it's removing, "thanks, but no" makes sense.

@oraNod
Copy link
Contributor

oraNod commented Oct 23, 2024

Cheers @x1101 I think we can just close this. I get that it can be helpful to put things into a doc as a way to get your head around stuff. I do that all the time myself. But, yeah, this might just get stale and then wind up confusing the next person who comes along.

@oraNod oraNod closed this Oct 23, 2024
@x1101 x1101 deleted the f_workflow_schedule_doc branch October 23, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants