-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct typos #2062
fix: correct typos #2062
Conversation
hsiangjenli
commented
Oct 25, 2024
•
edited
Loading
edited
- Removing the extra backtick
Thanks for your Ansible docs contribution! We talk about Ansible documentation on Matrix at #docs:ansible.im if you ever want to join us and chat about the docs! We meet on Matrix every Tuesday. See the Ansible calendar for meeting details. We welcome additions to our weekly agenda items too. You can add the |
Thanks for your contribution, @hsiangjenli! Please make sure that your pull request includes sufficient and meaningful details in the description. |
The following files are automatically generated and should not be modified outside of the Ansible release process:
Please double-check your changes. |
hey @hsiangjenli thanks very much for the fix! unfortunately, as pointed out in another comment the porting guides should not be edited directly. I'll poke around and see if I can find the correct source file for you. @samccann might also know where that is. |
@hsiangjenli Found it. The change should go into this file on the |
Normally, @oraNod is correct that we have to find the source of the error and fix it there. This is necessary because, for active releases, the porting guide is regenerated from changelog fragments for every minor update. So if we just fixed it here, it would get overwritten (and back to the same errors) on the next release. In this case though, both files are from EOL'd releases, which means we'll never regenerate those porting guides. So we can fix it in a PR like this one! |
Backport to stable-2.15: 💚 backport PR created✅ Backport PR branch: Backported as #2068 🤖 @patchback |
Thanks @hsiangjenli for the Ansible docs fix and welcome to the Ansible project! |
(cherry picked from commit a662334)
Backport to stable-2.16: 💚 backport PR created✅ Backport PR branch: Backported as #2069 🤖 @patchback |
(cherry picked from commit a662334)
Backport to stable-2.17: 💚 backport PR created✅ Backport PR branch: Backported as #2070 🤖 @patchback |
(cherry picked from commit a662334)
Backport to stable-2.18: 💚 backport PR created✅ Backport PR branch: Backported as #2071 🤖 @patchback |
(cherry picked from commit a662334)