Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing [] from --tags and --skip-tags #406

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

patrik93
Copy link
Contributor

@patrik93 patrik93 commented Sep 20, 2023

As it defined in the issue at #397, the brackets must be removed

Fixes #397

As it defined in the issue at ansible#397, the brackets must be removed
@github-actions github-actions bot added the needs_triage Needs a first human triage before being processed. label Sep 20, 2023
@gotmax23
Copy link
Collaborator

Thanks for your Ansible docs contribution! We talk about Ansible documentation on matrix at #docs:ansible.im and on libera IRC at #ansible-docs if you ever want to join us and chat about the docs! We meet there on Tuesdays (see the Ansible calendar) and welcome additions to our weekly agenda items - scroll down to find the upcoming agenda and add a comment to put something new on that agenda.

@gotmax23 gotmax23 added the new_contributor This PR is the first contribution by a new community member. label Sep 20, 2023
@samccann samccann removed the needs_triage Needs a first human triage before being processed. label Sep 20, 2023
Co-authored-by: Felix Fontein <felix@fontein.de>
@samccann samccann merged commit ea9559b into ansible:devel Sep 21, 2023
6 checks passed
@samccann
Copy link
Contributor

Thanks @patrik93 for the Ansible docs fix and welcome to the Ansible project!

@samccann samccann added backport-2.15 Automatically create a backport for the stable-2.15 branch backport-2.14 Automatically create a backport for the stable-2.14 branch backport-2.13 Automatically create a backport for the stable-2.13 branch backport-2.16 Automatically create a backport for the stable-2.16 branch labels Sep 21, 2023
@patchback
Copy link

patchback bot commented Sep 21, 2023

Backport to stable-2.14: 💔 cherry-picking failed — target branch does not exist

❌ Failed to fetch https://github.com/ansible/ansible-documentation.git

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Sep 21, 2023

Backport to stable-2.15: 💔 cherry-picking failed — target branch does not exist

❌ Failed to fetch https://github.com/ansible/ansible-documentation.git

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Sep 21, 2023

Backport to stable-2.13: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply ea9559b on top of patchback/backports/stable-2.13/ea9559b50deebb23f6f0826a6ee9a96f2e9564fa/pr-406

Backporting merged PR #406 into devel

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible/ansible-documentation.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-2.13/ea9559b50deebb23f6f0826a6ee9a96f2e9564fa/pr-406 upstream/stable-2.13
  4. Now, cherry-pick PR Removing [] from --tags and --skip-tags #406 contents into that branch:
    $ git cherry-pick -x ea9559b50deebb23f6f0826a6ee9a96f2e9564fa
    If it'll yell at you with something like fatal: Commit ea9559b50deebb23f6f0826a6ee9a96f2e9564fa is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x ea9559b50deebb23f6f0826a6ee9a96f2e9564fa
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Removing [] from --tags and --skip-tags #406 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-2.13/ea9559b50deebb23f6f0826a6ee9a96f2e9564fa/pr-406
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Sep 21, 2023

Backport to stable-2.16: 💔 cherry-picking failed — target branch does not exist

❌ Failed to fetch https://github.com/ansible/ansible-documentation.git

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein added backport-2.16 Automatically create a backport for the stable-2.16 branch and removed backport-2.15 Automatically create a backport for the stable-2.15 branch backport-2.14 Automatically create a backport for the stable-2.14 branch backport-2.16 Automatically create a backport for the stable-2.16 branch labels Sep 21, 2023
@patchback
Copy link

patchback bot commented Sep 21, 2023

Backport to stable-2.16: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.16/ea9559b50deebb23f6f0826a6ee9a96f2e9564fa/pr-406

Backported as #419

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 21, 2023
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit ea9559b)
@felixfontein felixfontein added backport-2.15 Automatically create a backport for the stable-2.15 branch backport-2.14 Automatically create a backport for the stable-2.14 branch labels Sep 21, 2023
@patchback
Copy link

patchback bot commented Sep 21, 2023

Backport to stable-2.14: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.14/ea9559b50deebb23f6f0826a6ee9a96f2e9564fa/pr-406

Backported as #420

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Sep 21, 2023

Backport to stable-2.15: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.15/ea9559b50deebb23f6f0826a6ee9a96f2e9564fa/pr-406

Backported as #421

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 21, 2023
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit ea9559b)
patchback bot pushed a commit that referenced this pull request Sep 21, 2023
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit ea9559b)
felixfontein pushed a commit that referenced this pull request Sep 21, 2023
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit ea9559b)

Co-authored-by: Patrik Hajnal <patrikhajnal93@gmail.com>
felixfontein pushed a commit that referenced this pull request Sep 21, 2023
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit ea9559b)

Co-authored-by: Patrik Hajnal <patrikhajnal93@gmail.com>
felixfontein pushed a commit that referenced this pull request Sep 21, 2023
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit ea9559b)

Co-authored-by: Patrik Hajnal <patrikhajnal93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2.13 Automatically create a backport for the stable-2.13 branch backport-2.14 Automatically create a backport for the stable-2.14 branch backport-2.15 Automatically create a backport for the stable-2.15 branch backport-2.16 Automatically create a backport for the stable-2.16 branch new_contributor This PR is the first contribution by a new community member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

right cli command for tags
4 participants