Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alert SSO user of token expiration #1050

Merged
merged 1 commit into from
Oct 7, 2021
Merged

alert SSO user of token expiration #1050

merged 1 commit into from
Oct 7, 2021

Conversation

ShaiahWren
Copy link
Contributor

Issue: AAH-952

Assignment: Warn SSO users of token expiration.

Note: Since I am not able to access the UI as a Keycloak user, I wasn't able to test the UI properly. If user.auth_provider returns ['django'] then the message will not appear.

@ShaiahWren ShaiahWren requested review from awcrosby and himdel October 7, 2021 16:10
@ShaiahWren ShaiahWren force-pushed the alert-user-of-token-expiration branch from 7e54afb to d42ac85 Compare October 7, 2021 18:46
@himdel
Copy link
Collaborator

himdel commented Oct 7, 2021 •
edited
Loading

With the above...
20211007195654

(screenshot is before with->will & seconds->minutes)

@ShaiahWren ShaiahWren force-pushed the alert-user-of-token-expiration branch from d42ac85 to 9e8436b Compare October 7, 2021 20:25
@ShaiahWren ShaiahWren requested a review from himdel October 7, 2021 20:33
@ShaiahWren ShaiahWren force-pushed the alert-user-of-token-expiration branch from 9e8436b to c1fe78e Compare October 7, 2021 20:36
@ShaiahWren ShaiahWren requested a review from himdel October 7, 2021 20:36
himdel
himdel approved these changes Oct 7, 2021
View reviewed changes
Copy link
Collaborator

@himdel himdel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20211007203927

👍

@ShaiahWren ShaiahWren merged commit a7f9425 into ansible:master Oct 7, 2021
@ShaiahWren ShaiahWren deleted the alert-user-of-token-expiration branch October 7, 2021 20:52
@himdel himdel added the backport-4.4 This PR should be backported to stable-4.4 (2.1) label Oct 7, 2021
@patchback
Copy link

patchback bot commented Oct 7, 2021 •
edited
Loading

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/a7f94256cbd2fc0bef668c6316fdd814d522c93b/pr-1050

Backported as #1051

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 7, 2021
@ShaiahWren
alert SSO user of token expiration (#1050)
f03ee35 
Pr closed.

(cherry picked from commit a7f9425)
@patchback patchback bot mentioned this pull request Oct 7, 2021
Merged
himdel pushed a commit that referenced this pull request Oct 8, 2021
@patchback @ShaiahWren
alert SSO user of token expiration (#1050) (#1051)
35d3281 
Pr closed.

(cherry picked from commit a7f9425)

Co-authored-by: Shaiah Emigh-Doyle <64337863+ShaiahWren@users.noreply.github.com>
@github-actions github-actions bot added the backported-4.4 This PR has been backported to stable-4.4 (2.1) label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

@awcrosby awcrosby Awaiting requested review from awcrosby

Assignees
No one assigned
Labels
backport-4.4 This PR should be backported to stable-4.4 (2.1) backported-4.4 This PR has been backported to stable-4.4 (2.1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaiahWren @himdel