lint:po - lint locale/*.po files to ensure same vars and components ({foo}, {0}, <0>, <0 />, </0>)
#1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
force-pushed
the
lint-po
branch
3 times, most recently
from
bf86986 to
32fcd51
Compare
|
Added a github actions error formatting, fixed the line numbers, removed the package.json for loop and rewritten in ruby...
|
himdel
added a commit
to himdel/lint-po
that referenced
this pull request
Nov 24, 2021
previous versions in ansible/ansible-hub-ui#1144
himdel
added a commit
to himdel/lint-po
that referenced
this pull request
Dec 5, 2021
himdel
added a commit
to himdel/lint-po
that referenced
this pull request
Dec 5, 2021
…{foo}, {0}, <0>, <0>, </0>)
* support filenames * support python %(foo)s format strings * add github action error formatter * use line number of the first line of msgstr
and python \w+ also matches `opération`
fix acceented chars, decouple error reporting from processing, DRY up state handling
`\w+` -> `[\p{Alpha}\p{Number}_]` & `/u`
easiest way to share between repos `pip install lint-po`
himdel
force-pushed
the
lint-po
branch
2 times, most recently
from
7869632 to
234f846
Compare
himdel
added a commit
to ansible/galaxy_ng
that referenced
this pull request
Dec 7, 2021
…1071) and re-run `plugin-template --github galaxy_ng` from https://github.com/pulp/plugin_template lint-po is https://pypi.org/project/lint-po/ , related to ansible/ansible-hub-ui#1144 (post-job-template seems to get evaluated with two spaces before the first line, so using an empty line to get both tasks at the same level) Issue: AAH-804
patchback bot
pushed a commit
to ansible/galaxy_ng
that referenced
this pull request
Dec 7, 2021
…1071) and re-run `plugin-template --github galaxy_ng` from https://github.com/pulp/plugin_template lint-po is https://pypi.org/project/lint-po/ , related to ansible/ansible-hub-ui#1144 (post-job-template seems to get evaluated with two spaces before the first line, so using an empty line to get both tasks at the same level) Issue: AAH-804 (cherry picked from commit 8adcc34)
himdel
added a commit
to ansible/galaxy_ng
that referenced
this pull request
Dec 7, 2021
…1071) (#1073) and re-run `plugin-template --github galaxy_ng` from https://github.com/pulp/plugin_template lint-po is https://pypi.org/project/lint-po/ , related to ansible/ansible-hub-ui#1144 (post-job-template seems to get evaluated with two spaces before the first line, so using an empty line to get both tasks at the same level) Issue: AAH-804 (cherry picked from commit 8adcc34) Co-authored-by: Martin Hradil <mhradil@redhat.com>
ZitaNemeckova
approved these changes
Dec 13, 2021
Backport to stable-4.4: 💚 backport PR created✅ Backport PR branch: Backported as #1369 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 13, 2021
…`{foo}`, `{0}`, `<0>`, `<0 />`, `</0>`) (#1144)
* lint:po - lint locale/*.po files to ensure same vars and components ({foo}, {0}, <0>, <0>, </0>)
* lint:po - convert to ruby
* support filenames
* support python %(foo)s format strings
* add github action error formatter
* use line number of the first line of msgstr
* lint:po - convert to python
and python \w+ also matches `opération`
* lint:po - convert to js
fix acceented chars, decouple error reporting from processing, DRY up state handling
`\w+` -> `[\p{Alpha}\p{Number}_]` & `/u`
* lint:po - use released pip package instead of a local script
easiest way to share between repos
`pip install lint-po`
(cherry picked from commit 05bbe11)
himdel
added a commit
that referenced
this pull request
Dec 13, 2021
…`{foo}`, `{0}`, `<0>`, `<0 />`, `</0>`) (#1144) (#1369)
* lint:po - lint locale/*.po files to ensure same vars and components ({foo}, {0}, <0>, <0>, </0>)
* lint:po - convert to ruby
* support filenames
* support python %(foo)s format strings
* add github action error formatter
* use line number of the first line of msgstr
* lint:po - convert to python
and python \w+ also matches `opération`
* lint:po - convert to js
fix acceented chars, decouple error reporting from processing, DRY up state handling
`\w+` -> `[\p{Alpha}\p{Number}_]` & `/u`
* lint:po - use released pip package instead of a local script
easiest way to share between repos
`pip install lint-po`
(cherry picked from commit 05bbe11)
Co-authored-by: Martin Hradil <mhradil@redhat.com>
github-actions
bot
added
the
backported-4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AAH-804
Quick and dirty *.po linter to check for common problems.
Right now, this will catch msgid/msgstr pairs with a different set of varible names, or components...
Related to #1143 (comment) (and thus #810)
And enabling on github actions, which should consequenty fail with the current
fr.poproblems :)(see image below)
Ended up moving the code to https://github.com/himdel/lint-po/, and releasing to pip as https://pypi.org/project/lint-po/ .
Backend PR ansible/galaxy_ng#1071