Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent deleting protected repositories #3580

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Prevent deleting protected repositories #3580

merged 2 commits into from
Apr 13, 2023

Conversation

jerabekjiri
Copy link
Contributor

@jerabekjiri jerabekjiri commented Apr 13, 2023 •
edited
Loading

Issue: AAH-2300

  • Close modal if the repository deletion fails
  • Disable delete button if the repository is protected (default)
    Screenshot from 2023-04-13 11-08-06
    image

Protected repositories: https://github.com/ansible/galaxy_ng/blob/master/galaxy_ng/app/access_control/access_policy.py#L465 (ansible/galaxy_ng#1671)

@github-actions github-actions bot added backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels Apr 13, 2023
@jerabekjiri jerabekjiri removed the backport-4.6 This PR should be backported to stable-4.6 (2.3) label Apr 13, 2023
@jerabekjiri
add .bug file
1baf7eb 
Issue: AAH-2300
@jerabekjiri jerabekjiri requested a review from himdel April 13, 2023 09:49
himdel
himdel approved these changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! 👍

@jerabekjiri jerabekjiri merged commit a0bda99 into ansible:master Apr 13, 2023
@patchback
Copy link

patchback bot commented Apr 13, 2023 •
edited
Loading

Backport to stable-4.7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.7/a0bda9927b49005b91ee6035336ee9c6b4d5e22a/pr-3580

Backported as #3583

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 13, 2023
@jerabekjiri @patchback
Prevent deleting protected repositories (#3580)
6920400 
* prevent deleting protected repositories
* add .bug file
Issue: AAH-2300

(cherry picked from commit a0bda99)
@patchback patchback bot mentioned this pull request Apr 13, 2023
Merged
himdel pushed a commit that referenced this pull request Apr 13, 2023
@patchback @jerabekjiri
Prevent deleting protected repositories (#3580) (#3583)
d413840 
* prevent deleting protected repositories
* add .bug file
Issue: AAH-2300

(cherry picked from commit a0bda99)

Co-authored-by: Jiří Jeřábek <Jerabekjirka@email.cz>
@github-actions github-actions bot added the backported-4.7 This PR has been backported to stable-4.7 (2.4) label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

Assignees
No one assigned
Labels
backport-4.7 This PR should be backported to stable-4.7 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerabekjiri @himdel