Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-4.7] Fix namespaces breadcrumb l10n (#3896) #3897

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Jun 27, 2023

to fix the l10n issue in #3896,
except we don't need the namespaces vs partners logic in the stable branches

=>

perl -i -npe 's/, namespaceBreadcrumb// if /from..src.paths/; s/namespaceBreadcrumb.url/formatPath(Paths.namespaces)/; s/namespaceBreadcrumb.name/t`Namespaces`/; s/namespaceBreadcrumb/{ name: t`Namespaces`, url: formatPath(Paths.namespaces) }/' src/**/*.*
vim src/paths.ts # manual cleanup of namespaceBreadcrumb
npm run prettier
npm run lint
and fixups

Issue: AAH-2433

to fix the l10n issue in ansible#3896,
except we don't need the namespaces vs partners logic in the stable branches

=>

    perl -i -npe 's/, namespaceBreadcrumb// if /from..src.paths/; s/namespaceBreadcrumb.url/formatPath(Paths.namespaces)/; s/namespaceBreadcrumb.name/t`Namespaces`/; s/namespaceBreadcrumb/{ name: t`Namespaces`, url: formatPath(Paths.namespaces) }/' src/**/*.*
    vim src/paths.ts # manual cleanup of namespaceBreadcrumb
    npm run prettier
    npm run lint
    and fixups

Issue: AAH-2433
@himdel himdel merged commit b498124 into ansible:stable-4.7 Jun 28, 2023
@himdel himdel deleted the 47-3896 branch June 28, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant