Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing collection, repository tests #4393

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Oct 12, 2023

collection: https://github.com/ansible/ansible-hub-ui/actions/runs/6501115433/job/17657814640?pr=4392
repository: https://github.com/ansible/ansible-hub-ui/actions/runs/6501115433/job/17657816163?pr=4392

the screenshot of the failures look like successes so trying to increase timeouts (or maybe we'll need a better selector for the "Completed" badge)
timeouts worked, trying to replace with galaxykit task wait all so we don't need random wait constants

@himdel himdel added the tests tests PR label Oct 12, 2023
@github-actions github-actions bot added backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Oct 12, 2023
@himdel himdel marked this pull request as ready for review October 12, 2023 23:04
@himdel himdel merged commit 0bac287 into ansible:master Oct 12, 2023
17 of 18 checks passed
@himdel himdel deleted the tests branch October 12, 2023 23:24
@patchback
Copy link

patchback bot commented Oct 12, 2023

Backport to stable-4.7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.7/0bac28741cdf1d9f1ae987b878b3161a3da9f0ff/pr-4393

Backported as #4394

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 12, 2023
* failing collection,repository test - try timeouts

No-Issue

* try wait all

(cherry picked from commit 0bac287)
@patchback
Copy link

patchback bot commented Oct 12, 2023

Backport to stable-4.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.8/0bac28741cdf1d9f1ae987b878b3161a3da9f0ff/pr-4393

Backported as #4395

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 12, 2023
* failing collection,repository test - try timeouts

No-Issue

* try wait all

(cherry picked from commit 0bac287)
himdel added a commit that referenced this pull request Oct 12, 2023
* failing collection,repository test - try timeouts

No-Issue

* try wait all

(cherry picked from commit 0bac287)

Co-authored-by: Martin Hradil <mhradil@redhat.com>
himdel added a commit that referenced this pull request Oct 12, 2023
* failing collection,repository test - try timeouts

No-Issue

* try wait all

(cherry picked from commit 0bac287)

Co-authored-by: Martin Hradil <mhradil@redhat.com>
@github-actions github-actions bot added backported-4.8 This PR has been backported to stable-4.8 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4) labels Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4) backported-4.8 This PR has been backported to stable-4.8 (2.4) tests tests PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant