Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack config - add IS_COMMUNITY & IS_INSIGHTS flags #4523

Merged
merged 5 commits into from
Nov 17, 2023

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Nov 17, 2023

Extracted from #4522

Add IS_COMMUNITY & IS_INSIGHTS flags, set based on the used webpack profile.

Replace non-lightspeed uses of featureFlags.ai_deny_index with a build mode check, these now use IS_COMMUNITY:

  • banner
  • canDeleteCommunityCollection
  • landing page
  • left nav Documentation link

Replace DEPLOYMENT_MODE === Constants.INSIGHTS_DEPLOYMENT_MODE with IS_INSIGHTS.

Unshare DEPLOYMENT_MODE from ui, remove unused constants, imports.

@github-actions github-actions bot added backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Nov 17, 2023
@himdel himdel added cleanup Dead code removal, etc and removed backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Nov 17, 2023
to allow for testing these features without switching API modes
himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Nov 17, 2023
@himdel himdel merged commit fbe6bbb into ansible:master Nov 17, 2023
17 of 18 checks passed
@himdel himdel deleted the is-flag branch November 17, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Dead code removal, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant