Add experimental rule for run_once #2626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
requested review from
a team,
cidrblock,
priyamsahoo and
shatakshiiii
ssbarnea
force-pushed
the
fix/new-rule
branch
from
d06806b to
98d6b1e
Compare
ssbarnea
force-pushed
the
fix/new-rule
branch
from
98d6b1e to
3fa4c98
Compare
|
What - a warning will be printed if strategy Edit: this PR is "sneaking" in a second warning that is not discussed or mentioned anywhere. Nowhere is a warning for Or is this because of limitations in ansible-lint? Only way to look at both play level and task level are 2 separate warnings? |
hswong3i
added a commit
to alvistack/ansible-role-ceph_osd
that referenced
this pull request
Nov 2, 2022
hswong3i
added a commit
to alvistack/ansible-role-ceph_mgr
that referenced
this pull request
Nov 2, 2022
hswong3i
added a commit
to alvistack/ansible-role-kube_cilium
that referenced
this pull request
Nov 2, 2022
hswong3i
added a commit
to alvistack/ansible-role-ceph_rgw
that referenced
this pull request
Nov 2, 2022
hswong3i
added a commit
to alvistack/ansible-role-ceph_mon
that referenced
this pull request
Nov 2, 2022
hswong3i
added a commit
to alvistack/ansible-role-ceph_mds
that referenced
this pull request
Nov 2, 2022
hswong3i
added a commit
to alvistack/ansible-role-kube_csi_cephfs
that referenced
this pull request
Nov 2, 2022
hswong3i
added a commit
to alvistack/ansible-role-kube_csi_hostpath
that referenced
this pull request
Nov 2, 2022
hswong3i
added a commit
to alvistack/ansible-role-kube_addon_manager
that referenced
this pull request
Nov 2, 2022
hswong3i
added a commit
to alvistack/ansible-role-kube_csi_rbd
that referenced
this pull request
Nov 2, 2022
hswong3i
added a commit
to alvistack/ansible-role-kube_registry
that referenced
this pull request
Nov 2, 2022
hswong3i
added a commit
to alvistack/ansible-role-kube_dashboard
that referenced
this pull request
Nov 2, 2022
hswong3i
added a commit
to alvistack/ansible-role-kube_node
that referenced
this pull request
Nov 2, 2022
hswong3i
added a commit
to alvistack/ansible-role-kube_master
that referenced
this pull request
Nov 2, 2022
hswong3i
added a commit
to alvistack/ansible-role-kube_cert_manager
that referenced
this pull request
Nov 2, 2022
hswong3i
added a commit
to alvistack/ansible-role-kube_metallb
that referenced
this pull request
Nov 2, 2022
hswong3i
added a commit
to alvistack/ansible-role-kube_ingress_nginx
that referenced
this pull request
Nov 2, 2022
hswong3i
added a commit
to alvistack/ansible-role-kube_weave
that referenced
this pull request
Nov 2, 2022
hswong3i
added a commit
to alvistack/ansible-role-kube_flannel
that referenced
this pull request
Nov 2, 2022
ssbarnea
added a commit
to ssbarnea/ansible-lint
that referenced
this pull request
Nov 11, 2022
Co-authored-by: Ajinkya <audgirka@redhat.com>
|
The logic in the rule is giving a warning, whenever I think, there are very legitimate use-cases for this keyword and it can be done in a predictable way. (we actually do this in our infrastructure). Also there's no hint in the Ansible reference docs, that the use of Please reconsider this PR and check only for the risky combination of |
robin-checkmk
added a commit
to Checkmk/ansible-collection-checkmk.general
that referenced
this pull request
Feb 21, 2023
Currently, the rule makes no sense and causes false positives for us. Reference: ansible/ansible-lint#2626
robin-checkmk
added a commit
to Checkmk/ansible-collection-checkmk.general
that referenced
this pull request
May 22, 2023
Currently, the rule makes no sense and causes false positives for us. Reference: ansible/ansible-lint#2626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1026
Closes: #2593