Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for raw booleans when using complex_conditional #3109

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Added support for raw booleans when using complex_conditional #3109

merged 1 commit into from
Mar 1, 2023

Conversation

audgirka
Copy link
Contributor

@audgirka audgirka commented Mar 1, 2023

Added

  • support for raw boolean when complex conditionals are passed a list.
  • tests

Fixes: #3105

@audgirka audgirka requested a review from a team as a code owner March 1, 2023 15:09
@audgirka audgirka requested review from a team, ssbarnea, priyamsahoo and shatakshiiii March 1, 2023 15:09
@audgirka audgirka added the bug label Mar 1, 2023
@ssbarnea
Copy link
Member

ssbarnea commented Mar 1, 2023

LGTM, thanks for fixing it quickly.

@ssbarnea ssbarnea merged commit 1c5148c into ansible:main Mar 1, 2023
@audgirka audgirka deleted the fix/complex_conditional_raw_boolean_support branch March 2, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema: complex_conditional doesn't support raw booleans in lists
2 participants
@audgirka @ssbarnea