Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor project root directory detection code #3295

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Refactor project root directory detection code #3295

merged 1 commit into from
Apr 17, 2023

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Apr 17, 2023

This changes the way linter determines project root folder to mimic the way black works. This will allow us to use linter to lint code that if outside current working directory and in path location like /tmp.

Related: #3284

Verified

This commit was signed with the committer’s verified signature.
ssbarnea Sorin Sbarnea
This changes the way linter determines project root folder to mimic
the way black works. This will allow us to use linter to lint code
that if outside current working directory and in path location like
/tmp.
@ssbarnea ssbarnea requested a review from a team as a code owner April 17, 2023 11:35
@ssbarnea ssbarnea requested review from a team, audgirka, shatakshiiii and Ruchip16 April 17, 2023 11:35
@github-actions github-actions bot added the bug label Apr 17, 2023
@ssbarnea ssbarnea changed the title Refactor project root directory code Refactor project root directory detection code Apr 17, 2023
@ssbarnea ssbarnea merged commit 8f02692 into main Apr 17, 2023
@ssbarnea ssbarnea deleted the fix/x branch April 17, 2023 12:43
ssbarnea added a commit that referenced this pull request Apr 20, 2023
Fixed bug introduced in #3295 which prevented the linter from
discovering the config file in a parent directory.
ssbarnea added a commit that referenced this pull request Apr 20, 2023
Fixed bug introduced in #3295 which prevented the linter from
discovering the config file in a parent directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants