Do not assume working_directory is github.workspace

[ajfabbri]

Setting working_directory for ansible-lint action would fail due to hard-coded .git, introduced in commit 6f728e0, when fetching .config/requirements-lock.txt.

This fix replaces .git with ${{ github.workspace }}/.git to make working_directory argument work again.

Tested that this does fix my github action, i.e.:

name: ansible-lint
on:
  pull_request:
    branches: ["main", "release/v*"]
jobs:
  build:
    name: Ansible Lint
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4

      - name: Run ansible-lint
        uses: ajfabbri/ansible-lint@main
        # this is broken :-( https://github.com/ansible/ansible-lint/issues/3938
        with:
          working_directory: iac

Fixes #3938

[commarla]

Thanks for this PR. I was waiting for this but then I encountered this bug actions/runner#2058
This solution does not working if running the action inside a container

[ptoscano]

Hi @ajfabbri,

this change unfortunately breaks the use case of checking out a repository in a subdirectory of the workspace and running ansible-lint in it, effectively reverting parts of #3905; in particular, now .git/ansible-lint-requirements.txt is assumed to be directly in the workspace, rather than where working_directory points to.

Example of workflow: https://github.com/RedHatInsights/ansible-collections-insights/blob/25a0213a4a955b44924c8439c3800f3f9157b76b/.github/workflows/ansible-lint.yml

      - name: Check out code
        uses: actions/checkout@v4
        with:
          path: ansible_collections/redhat/insights
[...]
      - name: Run ansible-lint
        uses: ansible/ansible-lint@v24
        with:
          working_directory: ansible_collections/redhat/insights

Failure due this change: https://github.com/RedHatInsights/ansible-collections-insights/actions/runs/9351931654/job/25740530216

Personally, I think working_directory ought to mean as base directory for everything, both git and sources; in case you want to run on a subdirectory of the git checkout, I'd recommend adding a separate parameter, e.g. repository_subdirectory (or something like that), and thus

      - uses: actions/checkout@v4
      - name: Run ansible-lint
        uses: ajfabbri/ansible-lint@main
        with:
          repository_subdirectory: iac

What do you think?

[ajfabbri]

Thanks for the report. I think we should try to support your case (checkouts not in top-level workspace dir) as well as monorepo users (those that don't put ansible files at the top level of their repository). I'm not an expert here, but It seems like the source of the problem is the use of .git/ as a /tmp directory to work around issues with python requirements.txt hashing?

Two ideas to fix that

1. Search ancestor dirs for .git until we find one (common git semantics for discovering repository from subdir). I.e. before the two steps that use the path ./git in this commit, we find the actual path to the first ancestor directory that contains .git/
2. Try workarounds mentioned in actions/toolkit/issues/1035