Make galaxy[version-incorrect] rule opt-in #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavcrosby
commented
Jul 6, 2024
cavcrosby
requested review from
priyamsahoo and
shatakshiiii
and removed request for
a team
The docstring and description attribute for the GalaxyRule class have been updated as to reflect the separation of galaxy[version-incorrect] and that the rule does more than checking of a changelog.
cavcrosby
force-pushed
the
make-galaxy-version-opt-in
branch
from
538f551 to
21fb079
Compare
for more information, see https://pre-commit.ci
|
alisonlhart
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #2103.
The changes I made primarily move what was already done in the linked issue over to a new rule to make it opt-in.