Improve --version behavior to handle remote disconnect #4276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavcrosby
requested review from
audgirka and
alisonlhart
and removed request for
a team
cavcrosby
force-pushed
the
handle-disconnect-version
branch
from
cd066a2 to
d8f506b
Compare
|
ssbarnea
approved these changes
Jul 31, 2024
ssbarnea
changed the title
|
@cavcrosby Thanks, good addition. Still, it does not fix the bug as we need to skip checking version when in offline mode. |
|
Yea, looking around again for some time, I think I have a direct fix for this. I'll push up another PR soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #4269