Fix quotes converting free-form syntax to yaml #4361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
previously requested changes
Oct 9, 2024
There was a problem hiding this comment.
I love this PR and I hope we can merge it soon. The only issue is that the produced file would be reformatted again by the linter to remove the unnecessary double quotes on this string.
Once we address this, we should be able to merge it.
That is how the transformed file should look:
msg: String with spaces
cavcrosby
force-pushed
the
fix-quotes-free-form-yaml
branch
from
e9ef02f to
21d8b21
Compare
cavcrosby
force-pushed
the
fix-quotes-free-form-yaml
branch
from
21d8b21 to
b6195b4
Compare
cavcrosby
requested review from
Qalthos and
alisonlhart
and removed request for
a team
cavcrosby
commented
Oct 10, 2024
cavcrosby
force-pushed
the
fix-quotes-free-form-yaml
branch
from
b6195b4 to
fc70356
Compare
cavcrosby
changed the title
YAML content has been changed to reflect that the YAML loader preserves quotes used in YAML and to utilize the preferred_quote attribute.
cavcrosby
force-pushed
the
fix-quotes-free-form-yaml
branch
from
fc70356 to
a41dd90
Compare
alisonlhart
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4319.