Refactor code to avoid use of rich library #4396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
changed the title
abhikdps
approved these changes
Dec 4, 2024
ssbarnea
removed
major
cidrblock
reviewed
Dec 6, 2024
| # Regex to find opening tags and their content | ||
| tag_pattern = re.compile(r"\[([\w\.]+)(?:=(.*?))?\]|\[/\]") | ||
|
|
||
| def replace_bb_links(text: str) -> str: |
There was a problem hiding this comment.
Can you get rid of these nested functions? It's really hard to grok.
|
|
||
| # Replace matches with HTML <a> tags | ||
|
|
||
| def replacement(match: re.Match[str]) -> str: |
| print(self.render(data), end=end, file=file or self._file, flush=flush) | ||
|
|
||
| def render(self, text: str) -> str: | ||
| """Parses a string containing nested BBCode with a generic block terminator ([/]).""" |
There was a problem hiding this comment.
Please add params to docstrings in google format :)
| class AnsiStyle(PlainStyle): | ||
| """Theme.""" | ||
|
|
||
| @dataclass |
There was a problem hiding this comment.
This is atypical, was there a need to nest this?
| file: TextIO | None = None, | ||
| flush: bool = False, | ||
| ) -> None: | ||
| """Internal print implementation.""" |
There was a problem hiding this comment.
Can you comment why this was necessary on the docstring?
| "success": (style.success, style.normal), | ||
| } | ||
| # Regex to find opening tags and their content | ||
| tag_pattern = re.compile(r"\[([\w\.]+)(?:=(.*?))?\]|\[/\]") |
There was a problem hiding this comment.
I've found putting the regex and the use of in it's own fn to make testing easier and demostrate what it does in the unit tests.
| DIM = "\033[1;30m" | ||
| BOLD_CYAN = "\033[1;36m" | ||
|
|
||
| warning = "\033[33m" # yellow |
There was a problem hiding this comment.
Can this ref the constant in ANSI?
| BOLD_CYAN = "\033[1;36m" | ||
|
|
||
| warning = "\033[33m" # yellow | ||
| error = ANSI.RED # "\033[31m" # red |
There was a problem hiding this comment.
Comment here probably not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://issues.redhat.com/browse/AAP-36125