Skip to content
This repository was archived by the owner on Oct 30, 2018. It is now read-only.

Conversation

@conrado
Copy link
Contributor

@conrado conrado commented Sep 29, 2014

it is quite common to initialize deployments with syncdb --all and migrate --fake

@gregdek
Copy link
Contributor

gregdek commented Jun 19, 2015

@conrado thanks for submitting this pull request. Please accept our apologies for taking so long to review it.

It appears that this PR needs to be rebased due to changes in the code base. If you believe that this PR still applies, please rebase and we will then put it into our review process.

@gregdek
Copy link
Contributor

gregdek commented Jul 16, 2015

@conrado A friendly reminder: this pull request has been marked as needing your action, and it hasn't been updated in the last month.

If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we'll keep it open pending your changes.

If we receive no indication from you within a week, we will close this pull request.

@conrado
Copy link
Contributor Author

conrado commented Jul 16, 2015

@gregdek ping

@gregdek
Copy link
Contributor

gregdek commented Jul 22, 2015

Ah, thanks @conrado for your response! Looks like it needs to be rebased now, though, so please do that and we will put it back into community_review.

@gregdek
Copy link
Contributor

gregdek commented Sep 12, 2015

@tastychutney Please review this PR to make sure it adheres to the following guidelines:

http://docs.ansible.com/developing_modules.html#module-checklist

If it passes these guidelines, and if you believe it’s a good PR otherwise, please add a comment with "shipit" in the text, and we will flag it for inclusion.

If it fails these guidelines, please add a comment with "needs_revision" in the text, along with the needed changes, and we will flag it for revision.

fixed: booleans are automatically cast by ansible.module_utils
updated: version options introduced
updated: documentation
@cchurch
Copy link
Contributor

cchurch commented Sep 17, 2015

Looks like it needs to be rebased again as a result of merging #1810...

@robynbergeron
Copy link

Hi @conrado -- sorry, looks like this needs a rebase, per @cchurch's comments. Getting ever closer :)

Once you have rebased this PR, please add a comment with the text "ready_for_review" and we will continue with the review process.

Thanks for continuing to see this one through, we appreciate it!

@gregdek gregdek removed the P3 label Mar 24, 2016
@gregdek
Copy link
Contributor

gregdek commented Apr 10, 2016

Closing due to contributor inactivity.

@gregdek gregdek closed this Apr 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants